beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2499) Fail to merge Custom Windows in Spark runner
Date Fri, 07 Jul 2017 16:03:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078293#comment-16078293
] 

ASF GitHub Bot commented on BEAM-2499:
--------------------------------------

GitHub user echauchot opened a pull request:

    https://github.com/apache/beam/pull/3517

    [BEAM-2499] Make SparkAbstractCombineFn generic to allow merging custom windows

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [X] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [X] Make sure tests pass via `mvn clean verify`.
     - [X] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [X] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    R: @amitsela 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/echauchot/beam BEAM-2499-interval_window_cast

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3517.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3517
    
----
commit a23b73a10fd7891b8eb3fe0d57ce22dc428ca51e
Author: Etienne Chauchot <echauchot@gmail.com>
Date:   2017-05-29T10:05:51Z

    [BEAM-2314] Add ValidatesRunner test for merging custom windows

commit 47aa570a312a1051d544bb1c17e165f31fd63117
Author: Etienne Chauchot <echauchot@gmail.com>
Date:   2017-07-06T12:31:26Z

    [BEAM-2499] Make SparkAbstractCombineFn generic to allow merging custom windows

commit 0a18986f06e3027278aca3176057d1b8e7b59100
Author: Etienne Chauchot <echauchot@gmail.com>
Date:   2017-07-07T15:34:23Z

    Remove exclusion of UsesCustomWindowMerging of Spark validatesRunner tests, now that Spark
supports it

----


> Fail to merge Custom Windows in Spark runner
> --------------------------------------------
>
>                 Key: BEAM-2499
>                 URL: https://issues.apache.org/jira/browse/BEAM-2499
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-spark
>            Reporter: Etienne Chauchot
>            Assignee: Etienne Chauchot
>
> If we extend {{IntervalWindow}} and we try to merge these custom windows like in this
PR:
> https://github.com/apache/beam/pull/3286
> Then spark runner fails with 
> {{org.apache.beam.sdk.Pipeline$PipelineExecutionException: java.lang.ClassCastException:
org.apache.beam.sdk.transforms.windowing.IntervalWindow cannot be cast to org.apache.beam.sdk.transforms.windowing.MergingCustomWindowsTest$CustomWindow}}
> It seems to be because of the cast to {{IntervalWindow}} there: https://github.com/apache/beam/blob/master/runners/spark/src/main/java/org/apache/beam/runners/spark/translation/SparkGlobalCombineFn.java#L111



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message