beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ahmet Altay (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2271) Release guide or pom.xml needs update to avoid releasing Python binary artifacts
Date Thu, 06 Jul 2017 20:33:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077163#comment-16077163
] 

Ahmet Altay commented on BEAM-2271:
-----------------------------------

We could not figure out how to generate the source zip file. (Tried variations of {{mvn clean
install -Prelease}}.)

In the release guide I _believe_ this happens at {{mvn release:prepare}} (https://beam.apache.org/contribute/release-guide/#build-and-stage-java-artifacts-with-maven)
step. But this step  requires being a committer ([~sb2nov] is not) and it has side effects
like creating tags.

What is is the mvn command for generating the source zip file?  

> Release guide or pom.xml needs update to avoid releasing Python binary artifacts
> --------------------------------------------------------------------------------
>
>                 Key: BEAM-2271
>                 URL: https://issues.apache.org/jira/browse/BEAM-2271
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py
>            Reporter: Daniel Halperin
>            Assignee: Sourabh Bajaj
>             Fix For: 2.1.0
>
>
> The following directories (and children) were discovered in 2.0.0-RC2 and were present
in 0.6.0.
> {code}
> sdks/python: build   dist    .eggs   nose-1.3.7-py2.7.egg  (and child contents)
> {code}
> Ideally, these artifacts, which are created during setup and testing, would get created
in the {{sdks/python/target/}} subfolder where they will automatically get ignored. More info
below.
> For 2.0.0, we will manually remove these files from the source release RC3+. This should
be fixed before the next release.
> Here is a list of other paths that get excluded, should they be useful.
> {code}
> <excludes>
>         <!-- build output -->
>         <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/).*${project.build.directory}.*]</exclude>
>         
>         <!-- NOTE: Most of the following excludes should not be required 
>              if the standard release process is followed. This is because the 
>              release plugin checks out project sources into a location like
>              target/checkout, then runs the build from there. The result is
>              a source-release archive that comes from a pretty clean directory
>              structure.
>              
>              HOWEVER, if the release plugin is configured to run extra goals
>              or generate a project website, it's definitely possible that some
>              of these files will be present. So, it's safer to exclude them.
>         -->
>              
>         <!-- IDEs -->
>         <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?maven-eclipse\.xml]</exclude>
>         <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?\.project]</exclude>
>         <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?\.classpath]</exclude>
>         <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?[^/]*\.iws]</exclude>
>         <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?\.idea(/.*)?]</exclude>
>         <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?out(/.*)?]</exclude>
>         <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?[^/]*\.ipr]</exclude>
>         <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?[^/]*\.iml]</exclude>
>         <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?\.settings(/.*)?]</exclude>
>         <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?\.externalToolBuilders(/.*)?]</exclude>
>         <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?\.deployables(/.*)?]</exclude>
>         <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?\.wtpmodules(/.*)?]</exclude>
>         
>         <!-- misc -->
>         <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?cobertura\.ser]</exclude>
>         
>         <!-- release-plugin temp files -->
>         <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?pom\.xml\.releaseBackup]</exclude>
>         <exclude>%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?release\.properties]</exclude>
>       </excludes>
> {code}
> This list is stored inside of this jar, which you can find by tracking maven-assembly-plugin
from the root apache pom: https://mvnrepository.com/artifact/org.apache.apache.resources/apache-source-release-assembly-descriptor/1.0.6
> http://svn.apache.org/repos/asf/maven/pom/tags/apache-18/pom.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message