beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1984) Enable dependency analysis of non-compile dependencies
Date Thu, 06 Jul 2017 03:51:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075882#comment-16075882
] 

ASF GitHub Bot commented on BEAM-1984:
--------------------------------------

Github user kennknowles closed the pull request at:

    https://github.com/apache/beam/pull/3488


> Enable dependency analysis of non-compile dependencies
> ------------------------------------------------------
>
>                 Key: BEAM-1984
>                 URL: https://issues.apache.org/jira/browse/BEAM-1984
>             Project: Beam
>          Issue Type: Improvement
>          Components: build-system
>    Affects Versions: Not applicable
>            Reporter: Ismaël Mejía
>            Assignee: Ismaël Mejía
>            Priority: Minor
>
> In the Beam parent pom at this moment we have a configuration on the maven dependency
plugin to ignore the verification of non-compile dependencies so unused or badly configured
dependencies that are used only for test or runtime purposes are not reported.
> {code:xml}
>               <!-- Ignore runtime-only dependencies in analysis -->
>               <ignoreNonCompile>true</ignoreNonCompile>
> {code}
> I discovered this case when I executed:
> {code}
> 	mvn clean install -Dmaven.test.skip=true
> {code}
> Notice that this is really particular because this does not compile the tests classes,
so it can detect when the ‘main’ classes are not using some code. This is different from
the behavior of:
> {code}
> 	mvn clean install -DskipTests=true
> {code}
> That does not complain because skipTests compiles the tests.
> For the first case (maven.test.skip) I got a warning ‘Unused declared dependencies
found’ so with this I discovered the test/runtime only dependencies that are not correctly
scoped. I will do a PR to fix this, because we can get rid of compile dependencies that are
test or runtime only.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message