beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1820) Source.getDefaultOutputCoder() should be @Nullable
Date Wed, 12 Jul 2017 12:56:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083930#comment-16083930
] 

ASF GitHub Bot commented on BEAM-1820:
--------------------------------------

GitHub user lgajowy opened a pull request:

    https://github.com/apache/beam/pull/3549

    [BEAM-1820] Make Source.getDefaultOutputCoder() @Nullable

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`.
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lgajowy/beam BEAM-1820_issue

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3549.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3549
    
----
commit ee744b9cdab340d46f93d765d9a3b38d979f77e0
Author: Łukasz Gajowy <lukasz.gajowy@polidea.com>
Date:   2017-07-07T17:51:59Z

    [BEAM-1820] Make Source.getDefaultOutputCoder() @Nullable

----


> Source.getDefaultOutputCoder() should be @Nullable
> --------------------------------------------------
>
>                 Key: BEAM-1820
>                 URL: https://issues.apache.org/jira/browse/BEAM-1820
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Eugene Kirpichov
>            Assignee: Łukasz Gajowy
>              Labels: easyfix, starter
>
> Source.getDefaultOutputCoder() returns a coder for elements produced by the source.
> However, the Source objects are nearly always hidden from the user and instead encapsulated
in a transform. Often, an enclosing transform has a better idea of what coder should be used
to encode these elements (e.g. a user supplied a Coder to that transform's configuration).
In that case, it'd be good if Source.getDefaultOutputCoder() could just return null, and coder
would have to be handled by the enclosing transform or perhaps specified on the output of
that transform explicitly.
> Right now there's a bunch of code in the SDK and runners that assumes Source.getDefaultOutputCoder()
returns non-null. That code would need to be fixed to instead use the coder set on the collection
produced by Read.from(source).
> It all appears pretty easy to fix, so this is a good starter item.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message