Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 95DDC200CB7 for ; Fri, 16 Jun 2017 00:07:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9486F160BF0; Thu, 15 Jun 2017 22:07:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DA7DE160BED for ; Fri, 16 Jun 2017 00:07:03 +0200 (CEST) Received: (qmail 46879 invoked by uid 500); 15 Jun 2017 22:07:03 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 46864 invoked by uid 99); 15 Jun 2017 22:07:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Jun 2017 22:07:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id B4E091A7A42 for ; Thu, 15 Jun 2017 22:07:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id QxV-gp-bZEXH for ; Thu, 15 Jun 2017 22:07:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 349165F297 for ; Thu, 15 Jun 2017 22:07:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7FEFAE0A32 for ; Thu, 15 Jun 2017 22:07:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 18DAB23FFF for ; Thu, 15 Jun 2017 22:07:00 +0000 (UTC) Date: Thu, 15 Jun 2017 22:07:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-2446) restrict scope of BeamSqlEnv in dsl query MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 15 Jun 2017 22:07:04 -0000 [ https://issues.apache.org/jira/browse/BEAM-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051145#comment-16051145 ] ASF GitHub Bot commented on BEAM-2446: -------------------------------------- GitHub user XuMingmin opened a pull request: https://github.com/apache/beam/pull/3372 [BEAM-2446] restrict scope of BeamSqlEnv in dsl query R: @xumingming @takidau You can merge this pull request into a Git repository by running: $ git pull https://github.com/XuMingmin/beam BEAM-2446 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/beam/pull/3372.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3372 ---- commit eb5852bd258212f3b50d760ea2b63bbcbd55c481 Author: mingmxu Date: 2017-06-14T18:50:31Z restrict the scope of BeamSqlEnv ---- > restrict scope of BeamSqlEnv in dsl query > ----------------------------------------- > > Key: BEAM-2446 > URL: https://issues.apache.org/jira/browse/BEAM-2446 > Project: Beam > Issue Type: Improvement > Components: dsl-sql > Reporter: Xu Mingmin > Assignee: Xu Mingmin > Labels: dsl_sql_merge > > Currently, the scope of BeamSqlEnv is global, that means all tables are accesible for each query, although it may not be related to the input PCollections in DSL methods. > For BeamSqlCli, it's reasonable to have a session BeamSqlEnv for each SQL client. > For BeamSql, each query should have its own BeamSqlEnv, which only has the input tables/PCollections. -- This message was sent by Atlassian JIRA (v6.4.14#64029)