Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 67E06200CA3 for ; Thu, 1 Jun 2017 18:20:16 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6659C160BC4; Thu, 1 Jun 2017 16:20:16 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AA65B160BB5 for ; Thu, 1 Jun 2017 18:20:15 +0200 (CEST) Received: (qmail 61569 invoked by uid 500); 1 Jun 2017 16:20:14 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 61554 invoked by uid 99); 1 Jun 2017 16:20:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Jun 2017 16:20:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 33963C0D9C for ; Thu, 1 Jun 2017 16:20:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id hKxt2ML3LwNf for ; Thu, 1 Jun 2017 16:20:11 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 10B825F5B3 for ; Thu, 1 Jun 2017 16:20:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4483CE0DD5 for ; Thu, 1 Jun 2017 16:20:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4EBEF21D62 for ; Thu, 1 Jun 2017 16:20:04 +0000 (UTC) Date: Thu, 1 Jun 2017 16:20:04 +0000 (UTC) From: "Antony Mayi (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (BEAM-2398) Increasing latency within DirectRunner caused by cumulated TransformWatermarks MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 01 Jun 2017 16:20:16 -0000 [ https://issues.apache.org/jira/browse/BEAM-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antony Mayi updated BEAM-2398: ------------------------------ Description: Over the time the end-to-end latency of a pipeline running on DirectRunner is significantly increasing. This is caused by ever growing sets of: * {{WatermarkManager.TransformWatermarks.inputWatermark.pendingElements}} * {{WatermarkManager.TransformWatermarks.synchronizedProcessingInputWatermark.pendingBundles}} That means calls to {{WatermarkManager.TransformWatermarks.refresh()}} which need to iterate through that collections take longer and longer and the latency is growing. I believe it is the line {{WaterMark.updatePending()}} line: {quote} if (input != null) { // Add the unprocessed inputs completedTransform.addPending(result.getUnprocessedInputs()); {quote} that's adding the items that are never removed. See attached [^LatencyTest.java] demo code showing the increasing latency. was: Over the time the end-to-end latency of a pipeline running on DirectRunner is significantly increasing. This is caused by ever growing sets of: * {{WatermarkManager.TransformWatermarks.inputWatermark.pendingElements}} * {{WatermarkManager.TransformWatermarks.synchronizedProcessingInputWatermark.pendingBundles}} That means calls to {{WatermarkManager.TransformWatermarks.refresh()}} which need to iterate through that collections take longer and longer and the latency is growing. I believe it is the line {{WaterMark.updatePending()}} line: {quote} if (input != null) { // Add the unprocessed inputs completedTransform.addPending(result.getUnprocessedInputs()); {quote} that's adding the items that are never removed. See attached demo code showing the increasing latency. > Increasing latency within DirectRunner caused by cumulated TransformWatermarks > ------------------------------------------------------------------------------ > > Key: BEAM-2398 > URL: https://issues.apache.org/jira/browse/BEAM-2398 > Project: Beam > Issue Type: Bug > Components: runner-direct > Affects Versions: 2.0.0 > Reporter: Antony Mayi > Assignee: Thomas Groh > Attachments: LatencyTest.java > > > Over the time the end-to-end latency of a pipeline running on DirectRunner is significantly increasing. > This is caused by ever growing sets of: > * {{WatermarkManager.TransformWatermarks.inputWatermark.pendingElements}} > * {{WatermarkManager.TransformWatermarks.synchronizedProcessingInputWatermark.pendingBundles}} > That means calls to {{WatermarkManager.TransformWatermarks.refresh()}} which need to iterate through that collections take longer and longer and the latency is growing. > I believe it is the line {{WaterMark.updatePending()}} line: > {quote} > if (input != null) { > // Add the unprocessed inputs > completedTransform.addPending(result.getUnprocessedInputs()); > {quote} > that's adding the items that are never removed. > See attached [^LatencyTest.java] demo code showing the increasing latency. -- This message was sent by Atlassian JIRA (v6.3.15#6346)