beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jeremiele <...@git.apache.org>
Subject [GitHub] beam pull request #3469: Properly convert milliseconds whether there's less ...
Date Thu, 29 Jun 2017 01:38:43 GMT
GitHub user jeremiele opened a pull request:

    https://github.com/apache/beam/pull/3469

    Properly convert milliseconds whether there's less than 3/more than 9…

    … digits.
    
    TimeUtil did not properly convert (and returned null) when the number of
    digits for fractions of seconds was less than 3 digits or more than 9 digits.
    The solution is to pad with zeros when there is less than 3 digits and to
    truncate when there is more than 3.
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jeremiele/beam fix_timeutil

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3469.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3469
    
----
commit a9eabcaa63ff96ae1051f03dc80e89ef0c655f80
Author: Jeremie Lenfant-Engelmann <jeremiele@google.com>
Date:   2017-06-29T01:32:56Z

    Properly convert milliseconds whether there's less than 3/more than 9 digits.
    TimeUtil did not properly convert (and returned null) when the number of
    digits for fractions of seconds was less than 3 digits or more than 9 digits.
    The solution is to pad with zeros when there is less than 3 digits and to
    truncate when there is more than 3.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message