beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] beam pull request #3429: [BEAM-2502] Ignore processing time timers in expire...
Date Fri, 23 Jun 2017 01:13:37 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/3429

    [BEAM-2502] Ignore processing time timers in expired windows

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`.
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    Technically, the test added here is OK to fail - it is a race condition anyhow whether
GC clears the state or the processing time timer "makes it in time". But for consistency,
I think expired windows should not incur further processing.
    
    R: @bjchambers 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam ReduceFnRunner

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3429.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3429
    
----
commit 9f9ec3d40687e862daaff55a668e5c006de5af2c
Author: Kenneth Knowles <klk@google.com>
Date:   2017-06-23T01:09:11Z

    Ignore processing time timers in expired windows

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message