beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Sisk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2460) Make python maven variables available elsewhere
Date Tue, 20 Jun 2017 22:10:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16056558#comment-16056558
] 

Stephen Sisk commented on BEAM-2460:
------------------------------------

With a bit more investigation, I've landed on the following solution:

We will copy the groovy-maven-plugin invocation into the poms that need it, and use project.parent.parent.[...].basedir
to create a path that points at findSupportedPython.groovy

So for the jdbc pom, this looks like:
          <plugin>
            <groupId>org.codehaus.gmaven</groupId>
            <artifactId>groovy-maven-plugin</artifactId>
            <version>${groovy-maven-plugin.version}</version>
            <executions>
              <execution>
                <id>find-supported-python-for-compile</id>
                <phase>initialize</phase>
                <goals>
                  <goal>execute</goal>
                </goals>
                <configuration>
                  <source>${project.parent.parent.parent.parent.basedir}/sdks/python/findSupportedPython.groovy</source>
                </configuration>
              </execution>
            </executions>
          </plugin>

Where the project.parent.parent.parent... is specific to the directory that it's in.

Conveniently, this will be the same for all the poms, so copy-pasting it will work seamlessly
with the io poms. I won't say I'm a big fan of this solution, but given the alternatives,
this seems like the least horrible one.



> Make python maven variables available elsewhere
> -----------------------------------------------
>
>                 Key: BEAM-2460
>                 URL: https://issues.apache.org/jira/browse/BEAM-2460
>             Project: Beam
>          Issue Type: Task
>          Components: sdk-java-core, sdk-py
>            Reporter: Stephen Sisk
>            Assignee: Stephen Sisk
>            Priority: Minor
>
> We're planning to start using perfkit to make it easy for users to run the IO ITs. Perfkit
is a python app, so we'll need to invoke the python interpreter. 
> findSupportedPython calculates this and sets the python.interpreter.bin variable. It
currently does so in the python project. 
> I believe the correct answer here is to move findSupportedPython so that's it's invoked
in the root pom. (but perhaps there's a more maven-y approach to this problem?) 
> cc [~altay] [~markflyhigh] [~jasonkuster] [~davor]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message