beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Sisk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2460) Make python maven variables available elsewhere
Date Tue, 20 Jun 2017 20:21:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16056396#comment-16056396
] 

Stephen Sisk commented on BEAM-2460:
------------------------------------

okay, this is more complex than I had hoped.See https://stackoverflow.com/questions/6061537/usage-of-maven-basedir-in-multi-module-setup
but basically getting a path to a file that is accessed from multiple modules is a pain. 


It appears we need to choose between:
1) copying the code from findSupportedPython into the root pom. It's not a lot of code, but
it's probably too much.
2) use a workaround that sets a per-project variable - https://stackoverflow.com/questions/1012402/maven2-property-that-indicates-the-parent-directory


I'm open to other suggestions - for now I'm going to try out #2 to see if that works the way
we want it to.

> Make python maven variables available elsewhere
> -----------------------------------------------
>
>                 Key: BEAM-2460
>                 URL: https://issues.apache.org/jira/browse/BEAM-2460
>             Project: Beam
>          Issue Type: Task
>          Components: sdk-java-core, sdk-py
>            Reporter: Stephen Sisk
>            Assignee: Stephen Sisk
>            Priority: Minor
>
> We're planning to start using perfkit to make it easy for users to run the IO ITs. Perfkit
is a python app, so we'll need to invoke the python interpreter. 
> findSupportedPython calculates this and sets the python.interpreter.bin variable. It
currently does so in the python project. 
> I believe the correct answer here is to move findSupportedPython so that's it's invoked
in the root pom. (but perhaps there's a more maven-y approach to this problem?) 
> cc [~altay] [~markflyhigh] [~jasonkuster] [~davor]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message