beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2444) DSL SQL: Use standard java exceptions instead of custom ones
Date Thu, 15 Jun 2017 02:59:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049938#comment-16049938
] 

ASF GitHub Bot commented on BEAM-2444:
--------------------------------------

GitHub user xumingming opened a pull request:

    https://github.com/apache/beam/pull/3365

    [BEAM-2444] BeamSql: use java standard exception

    R: @XuMingmin 
    R: @takidau 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xumingming/beam BEAM-2444-use-java-standard-exception

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3365.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3365
    
----
commit 83e6c2046571c14d104e622b2e2ad656143e09aa
Author: James Xu <xumingmingv@gmail.com>
Date:   2017-06-15T02:57:10Z

    [BEAM-2444] BeamSql: use java standard exception

----


> DSL SQL: Use standard java exceptions instead of custom ones
> ------------------------------------------------------------
>
>                 Key: BEAM-2444
>                 URL: https://issues.apache.org/jira/browse/BEAM-2444
>             Project: Beam
>          Issue Type: Improvement
>          Components: dsl-sql
>            Reporter: Luke Cwik
>            Assignee: James Xu
>            Priority: Minor
>              Labels: dsl_sql_merge
>
> Remove the Beam SQL exception type and use the standard Java one with the same purpose.
> Beam SQL exception types:
> {code}
> org.apache.beam.dsls.sql.exception.BeamSqlUnsupportedException
> org.apache.beam.dsls.sql.schema.UnsupportedDataTypeException
> org.apache.beam.dsls.sql.exception.InvalidFieldException
> org.apache.beam.dsls.sql.exception.BeamInvalidOperatorException
> {code}
> Suggested alternatives depending on the context of where/why exception is being thrown:
> {code}
> java.lang.UnsupportedOperationException
> java.lang.IllegalArgumentException
> java.lang.IllegalStateException
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message