beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2423) Abstract StateInternalsTest for the different state internals/Runners
Date Tue, 13 Jun 2017 03:30:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16047376#comment-16047376
] 

ASF GitHub Bot commented on BEAM-2423:
--------------------------------------

GitHub user JingsongLi opened a pull request:

    https://github.com/apache/beam/pull/3348

    [BEAM-2423] Port state internals tests to the new base class StateInternalsTest

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JingsongLi/beam PortStateInternalsTest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3348.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3348
    
----
commit 00ec33b98f4e041c88b4ae3fd609825405a69fd2
Author: JingsongLi <lzljs3620320@aliyun.com>
Date:   2017-06-13T03:26:38Z

    [BEAM-2423] Port state internals tests to the new base class StateInternalsTest

----


> Abstract StateInternalsTest for the different state internals/Runners
> ---------------------------------------------------------------------
>
>                 Key: BEAM-2423
>                 URL: https://issues.apache.org/jira/browse/BEAM-2423
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-core, runner-flink
>            Reporter: Jingsong Lee
>            Assignee: Jingsong Lee
>             Fix For: 2.1.0
>
>
> For the test of InMemoryStateInternals, ApexStateInternals, FlinkStateInternals, SparkStateInternals,
etc..
> Have a common base class for the state internals test that has an abstract method createStateInternals()
and all the test methods. Then an actual implementation would just derive from that and only
implement the method for creating the state internals. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message