beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2392) Avoid use of proto builder clone
Date Tue, 27 Jun 2017 16:42:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065092#comment-16065092
] 

ASF GitHub Bot commented on BEAM-2392:
--------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/3415


> Avoid use of proto builder clone
> --------------------------------
>
>                 Key: BEAM-2392
>                 URL: https://issues.apache.org/jira/browse/BEAM-2392
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-gcp
>    Affects Versions: 2.1.0
>            Reporter: Nigel Kilmer
>            Assignee: Nigel Kilmer
>            Priority: Minor
>
> BigtableServiceImpl uses the clone method of the MutateRowResponse proto builder here:
> https://github.com/apache/beam/blob/04e3261818aed0c129e7c715e371463bf5b5c1b8/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceImpl.java#L212
> This method is not generated by the Google-internal Java proto generator, so I had to
change this to get it to work with an internal project. Are you interested in adding this
change to the main repository for compatibility, or would you prefer to keep the cleaner version
that uses clone?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message