beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Knowles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2140) Fix SplittableDoFn ValidatesRunner tests in FlinkRunner
Date Tue, 27 Jun 2017 17:57:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065211#comment-16065211
] 

Kenneth Knowles commented on BEAM-2140:
---------------------------------------

Taking a step back, I don't feel strongly that it needs to be possible to implement SDF via
StateInternals + TimerInternals, without any further runner awareness. If the natural semantics
for state and timers don't fit, we shouldn't make them unnatural for this case. They are used
for triggers and it has taken some time to mature the design, so changing their semantics
has real risks. But these _are_ just internals, so we should also feel free to adjust them
if we come up with a strong new design.

> Fix SplittableDoFn ValidatesRunner tests in FlinkRunner
> -------------------------------------------------------
>
>                 Key: BEAM-2140
>                 URL: https://issues.apache.org/jira/browse/BEAM-2140
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-flink
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>
> As discovered as part of BEAM-1763, there is a failing SDF test. We disabled the tests
to unblock the open PR for BEAM-1763.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message