beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Knowles (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (BEAM-2140) Fix SplittableDoFn ValidatesRunner tests in FlinkRunner
Date Mon, 26 Jun 2017 18:50:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063594#comment-16063594
] 

Kenneth Knowles edited comment on BEAM-2140 at 6/26/17 6:49 PM:
----------------------------------------------------------------

There is an open need to be able to set a timer with an associated _output_ watermark hold,
which may be related. This has come up in conversation with [~reuvenlax].

For a processing time timer, it would be like {{timer.withOutputTime(new Instant(...)).setRelative(...)}}
and for an event time timer, it would look similarly like {{timer.withOutputTime(new Instant(...)).set(...))}}.
These permit the {{@OnTimer}} callback to output elements with that timestamp. Both also manifest
as output watermark holds.

It sounds like you want to set an event time timer if you want it to be fired on the input
watermark going to +inf.


was (Author: kenn):
There is an open need to be able to set a timer with an associated _output_ watermark hold,
which may be related. This has come up in conversation with [~reuvenlax].

For a processing time timer, it would be like {{timer.withOutputTime(new Instant(...)).setRelative(...)}}
and for an event time timer, it would look similarly like {{timer.withOutputTime(new Instant(...)).set(...))}}
and this would

These permit the {{@OnTimer}} callback to output elements with that timestamp. Both also manifest
as output watermark holds.

It sounds like you want to set an event time timer if you want it to be fired on the input
watermark going to +inf.

> Fix SplittableDoFn ValidatesRunner tests in FlinkRunner
> -------------------------------------------------------
>
>                 Key: BEAM-2140
>                 URL: https://issues.apache.org/jira/browse/BEAM-2140
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-flink
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>
> As discovered as part of BEAM-1763, there is a failing SDF test. We disabled the tests
to unblock the open PR for BEAM-1763.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message