beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eugene Kirpichov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2140) Fix SplittableDoFn ValidatesRunner tests in FlinkRunner
Date Mon, 26 Jun 2017 18:18:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063548#comment-16063548
] 

Eugene Kirpichov commented on BEAM-2140:
----------------------------------------

On 1: the timer should not be dropped because ProcessFn is setting a watermark hold (bullet
3 in my previous comment here).

On 2: correct, it uses the low-level state/timer APIs - partially because it was written before
the high-level APIs were available; partially because the high-level APIs don't support watermark
holds; partially because we didn't want to tie the availability of one complex feature in
a runner to the availability of another complex feature.

> Fix SplittableDoFn ValidatesRunner tests in FlinkRunner
> -------------------------------------------------------
>
>                 Key: BEAM-2140
>                 URL: https://issues.apache.org/jira/browse/BEAM-2140
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-flink
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>
> As discovered as part of BEAM-1763, there is a failing SDF test. We disabled the tests
to unblock the open PR for BEAM-1763.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message