beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ismaël Mejía (JIRA) <j...@apache.org>
Subject [jira] [Commented] (BEAM-1531) Support dynamic work rebalancing for HBaseIO
Date Thu, 29 Jun 2017 07:54:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067943#comment-16067943
] 

Ismaël Mejía commented on BEAM-1531:
------------------------------------

Oh I see, I somehow misinterpreted that you wanted to bake the full FakeService route sorry.
I agree with what you said, it is a tradeoff and I think for the speed improvement and similar
accuracy it is worth to apply your changes, so I am taking your commit and applying it with
some minor changes.
Thanks a lot, great improvement !

I expect that we will have some feedback for the reasons why the exhaustive test time grows
so much with the native implementation at the review time. I am going to ask [~jkff] to take
a look at the PR because he wrote the asserts that the test case uses, so probably he understands
better.

> Support dynamic work rebalancing for HBaseIO
> --------------------------------------------
>
>                 Key: BEAM-1531
>                 URL: https://issues.apache.org/jira/browse/BEAM-1531
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-extensions
>            Reporter: Ismaël Mejía
>            Assignee: Ismaël Mejía
>            Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message