beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Innocent (JIRA)" <>
Subject [jira] [Commented] (BEAM-766) Trigger AST should use @AutoValue
Date Mon, 19 Jun 2017 23:47:00 GMT


Innocent commented on BEAM-766:

I thought about applying the @AutoValue annotation on the Trigger class in Windowing Trigger
since every other Trigger derives directly from it. looking at the implementation of equals
in the class, I have doubt that the implementation generated by @AutoValue will be equivalent
to that one. This might actually be wrong any guidance?

> Trigger AST should use @AutoValue
> ---------------------------------
>                 Key: BEAM-766
>                 URL:
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Innocent
>            Priority: Trivial
>              Labels: easy, starter
> Triggers are already enriched POJOs that could use {{@AutoValue}}. Certainly once they
are converted to a simple AST this is the way to go.

This message was sent by Atlassian JIRA

View raw message