Mailing-List: contact commits-help@beam.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.apache.org
From: reuvenlax <git@git.apache.org>
To: commits@beam.apache.org
Reply-To: commits@beam.apache.org
Message-ID: <git-pr-3232-beam@git.apache.org>
Subject: [GitHub] beam pull request #3232: [BEAM-2276] Cleanups to windowed DefaultFilenamePol...
Content-Type: text/plain
Date: Fri, 26 May 2017 06:48:11 +0000 (UTC)
archived-at: Fri, 26 May 2017 06:48:13 -0000

GitHub user reuvenlax opened a pull request:

    https://github.com/apache/beam/pull/3232

    [BEAM-2276] Cleanups to windowed DefaultFilenamePolicy

    Make window strings more concise, and provide more information about the pane more concisely (most users care about whether a pane is the last one, and whether it is late).
    
    Cleanup complicated code around filename templates - simply store two default templates, and pick the correct one based on whether windowed writes are enabled.
    
    Remove log statements that would be extremely noisy in practice. Users may have valid reasons for not including W and P template variables - e.g. they may know they are in the global window and not want every file to contain GlobalWindow. This is the same reason we don't warn if S and N are missing from their template (they may be writing to a single shard).
    
    R: @jbonofre 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/reuvenlax/incubator-beam cleanup_filename_policy

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3232.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3232
    
----
commit ea451387bbee9a1c9ed037751d35868a61fa9042
Author: Reuven Lax <relax@google.com>
Date:   2017-05-26T06:42:17Z

    Some cleanups.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---