Return-Path: <commits-return-36723-archive-asf-public=cust-asf.ponee.io@beam.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id AFE93200C81
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri, 12 May 2017 02:31:42 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id AE9AB160BCA; Fri, 12 May 2017 00:31:42 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 25653160BC7
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 12 May 2017 02:31:41 +0200 (CEST)
Received: (qmail 17360 invoked by uid 500); 12 May 2017 00:31:41 -0000
Mailing-List: contact commits-help@beam.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@beam.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@beam.apache.org>
List-Post: <mailto:commits@beam.apache.org>
List-Id: <commits.beam.apache.org>
Reply-To: dev@beam.apache.org
Delivered-To: mailing list commits@beam.apache.org
Received: (qmail 17351 invoked by uid 99); 12 May 2017 00:31:41 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 May 2017 00:31:41 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 390B9DFC2E; Fri, 12 May 2017 00:31:41 +0000 (UTC)
From: sb2nov <git@git.apache.org>
To: commits@beam.apache.org
Reply-To: commits@beam.apache.org
Message-ID: <git-pr-3111-beam@git.apache.org>
Subject: [GitHub] beam pull request #3111: Beam rename FileSink to FileBasedSink
Content-Type: text/plain
Date: Fri, 12 May 2017 00:31:41 +0000 (UTC)
archived-at: Fri, 12 May 2017 00:31:42 -0000

GitHub user sb2nov opened a pull request:

    https://github.com/apache/beam/pull/3111

    Beam rename FileSink to FileBasedSink

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    R: @chamikaramj  @aaltay PTAL


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sb2nov/beam BEAM-rename-filesink

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3111.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3111
    
----
commit 82f7204bee41a644a9f6f1537764dbea49cb0f59
Author: Sourabh Bajaj <sourabhbajaj@google.com>
Date:   2017-05-12T00:23:40Z

    Rename filesink to filebasedsink

commit b394a2b5b9d6a98f6815c8d95c66a5426c910388
Author: Sourabh Bajaj <sourabhbajaj@google.com>
Date:   2017-05-12T00:29:51Z

    Rename fileio to filebasedsink

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---