Mailing-List: contact commits-help@beam.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.apache.org
From: vikkyrk <git@git.apache.org>
To: commits@beam.apache.org
Reply-To: commits@beam.apache.org
Message-ID: <git-pr-2996-beam@git.apache.org>
Subject: [GitHub] beam pull request #2996: [BEAM-1871] [BEAM-1019 ] Shade dependencies in sdks...
Content-Type: text/plain
Date: Tue,  9 May 2017 19:09:51 +0000 (UTC)
archived-at: Tue, 09 May 2017 19:09:53 -0000

GitHub user vikkyrk opened a pull request:

    https://github.com/apache/beam/pull/2996

    [BEAM-1871] [BEAM-1019 ] Shade dependencies in sdks/core

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    - Shade `com.google.guava:guava`, `com.google.protobuf:protobuf-java`, `net.bytebuddy:byte-buddy`, `org.apache.commons:*`
    - Shading `net.bytebuddy` fails the `GcpApiSurfaceTest` with `NoClassDefFoundError` for ` org/apache/beam/sdk/repackaged/net/bytebuddy/jar/asm/tree/MethodNode`. Looks like an issue with how `net.bytebuddy` does shading for `org.objectweb.asm`. Either way the `ApiSurfaceTest` should be fixed to be able to prune and load classes lazily. For release-2.0.0 we catch and ignore any class loading errors.  

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vikkyrk/incubator-beam shade_2.0.0

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2996.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2996
    
----
commit feee8daa0f90eb779edb44b4cfafcee6b7ac7faf
Author: Vikas Kedigehalli <vikasrk@google.com>
Date:   2017-05-09T18:41:29Z

    Shade dependencies in sdks/core

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---