Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DDAAA200C68 for ; Wed, 3 May 2017 18:19:59 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id DC5E9160BBA; Wed, 3 May 2017 16:19:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 37D2D160BAA for ; Wed, 3 May 2017 18:19:59 +0200 (CEST) Received: (qmail 37711 invoked by uid 500); 3 May 2017 16:19:58 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 37698 invoked by uid 99); 3 May 2017 16:19:58 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 May 2017 16:19:58 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 513A0E028C; Wed, 3 May 2017 16:19:58 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: kenn@apache.org To: commits@beam.apache.org Date: Wed, 03 May 2017 16:19:58 -0000 Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: [1/2] beam git commit: Use LinkedHashMap for step contexts in BaseExecutionContext archived-at: Wed, 03 May 2017 16:20:00 -0000 Repository: beam Updated Branches: refs/heads/master 1b0400fee -> f33039bfd Use LinkedHashMap for step contexts in BaseExecutionContext This gives a performance improvement when all step contexts need to be traversed, such as for state cleanup operations. Project: http://git-wip-us.apache.org/repos/asf/beam/repo Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/84255c4b Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/84255c4b Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/84255c4b Branch: refs/heads/master Commit: 84255c4bcbd10b37179a0ee883e3bd577c9c6172 Parents: 3b61f6a Author: Kenneth Knowles Authored: Wed May 3 07:54:50 2017 -0700 Committer: Kenneth Knowles Committed: Wed May 3 07:57:36 2017 -0700 ---------------------------------------------------------------------- .../java/org/apache/beam/runners/core/BaseExecutionContext.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/beam/blob/84255c4b/runners/core-java/src/main/java/org/apache/beam/runners/core/BaseExecutionContext.java ---------------------------------------------------------------------- diff --git a/runners/core-java/src/main/java/org/apache/beam/runners/core/BaseExecutionContext.java b/runners/core-java/src/main/java/org/apache/beam/runners/core/BaseExecutionContext.java index aa1474c..8d68256 100644 --- a/runners/core-java/src/main/java/org/apache/beam/runners/core/BaseExecutionContext.java +++ b/runners/core-java/src/main/java/org/apache/beam/runners/core/BaseExecutionContext.java @@ -20,7 +20,7 @@ package org.apache.beam.runners.core; import java.io.IOException; import java.util.Collection; import java.util.Collections; -import java.util.HashMap; +import java.util.LinkedHashMap; import java.util.Map; import org.apache.beam.sdk.coders.Coder; import org.apache.beam.sdk.transforms.DoFn.Context; @@ -53,7 +53,7 @@ import org.apache.beam.sdk.values.TupleTag; public abstract class BaseExecutionContext implements ExecutionContext { - private Map cachedStepContexts = new HashMap<>(); + private Map cachedStepContexts = new LinkedHashMap<>(); /** * Implementations should override this to create the specific type