Mailing-List: contact commits-help@beam.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.apache.org
Date: Wed, 24 May 2017 16:37:04 +0000 (UTC)
From: "Nicholas Ursa (JIRA)" <jira@apache.org>
To: commits@beam.apache.org
Message-ID: <JIRA.13074556.1495641202000.284991.1495643824330@Atlassian.JIRA>
In-Reply-To: <JIRA.13074556.1495641202000@Atlassian.JIRA>
References: <JIRA.13074556.1495641202000@Atlassian.JIRA> <JIRA.13074556.1495641202857@jira-lw-us.apache.org>
Subject: [jira] [Comment Edited] (BEAM-2358) "/test-your-pipeline" example
 code results in an exception
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 24 May 2017 16:37:10 -0000


    [ https://issues.apache.org/jira/browse/BEAM-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023187#comment-16023187 ] 

Nicholas Ursa edited comment on BEAM-2358 at 5/24/17 4:36 PM:
--------------------------------------------------------------

@Rule only works on methods and fields, so this means you wouldn't be able to create a pipeline in a local variable, which seems overly restrictive.

{code}
@Retention(RetentionPolicy.RUNTIME)
@Target({ElementType.FIELD, ElementType.METHOD})
public @interface Rule {

}
{code}

The change in code came out of this ticket: https://issues.apache.org/jira/browse/BEAM-1205


was (Author: nicku33):
@Rule only works on methods and fields, so this means you wouldn't be able to create a pipeline in a method, which seems overly restrictive.

{code}
@Retention(RetentionPolicy.RUNTIME)
@Target({ElementType.FIELD, ElementType.METHOD})
public @interface Rule {

}
{code}

The change in code came out of this ticket: https://issues.apache.org/jira/browse/BEAM-1205


> "/test-your-pipeline" example code results in an exception
> ----------------------------------------------------------
>
>                 Key: BEAM-2358
>                 URL: https://issues.apache.org/jira/browse/BEAM-2358
>             Project: Beam
>          Issue Type: Bug
>          Components: website
>            Reporter: Nicholas Ursa
>            Assignee: Davor Bonaci
>              Labels: documentation, easyfix
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> https://beam.apache.org/documentation/pipelines/test-your-pipeline/ has
> {code}
>  public void testCountWords() throws Exception {
>       Pipeline p = TestPipeline.create();
> {code}
> but this results in 
> {code}
> Exception in thread "main" java.lang.IllegalStateException: Is your TestPipeline declaration missing a @Rule annotation? Usage: @Rule public final transient TestPipeline pipeline = TestPipeline.Create();
> 	at org.apache.beam.sdk.repackaged.com.google.common.base.Preconditions.checkState(Preconditions.java:444)
> 	at org.apache.beam.sdk.testing.TestPipeline.run(TestPipeline.java:299)
> 	at BasicPipelineTest.run(BasicPipelineTest.java:42)
> 	at Main.main(Main.java:25)
> {code}
> In the [github example|https://github.com/apache/beam/blob/master/examples/java8/src/test/java/org/apache/beam/examples/MinimalWordCountJava8Test.java#L56]
>  it's written as:
> {code}
> public TestPipeline p = TestPipeline.create().enableAbandonedNodeEnforcement(false);
> {code}
> I'm using 2.0.0 from the maven repo.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)