Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E574D200C7F for ; Wed, 24 May 2017 15:10:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E40BB160BB4; Wed, 24 May 2017 13:10:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 36FDC160B9C for ; Wed, 24 May 2017 15:10:08 +0200 (CEST) Received: (qmail 95114 invoked by uid 500); 24 May 2017 13:10:07 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 95104 invoked by uid 99); 24 May 2017 13:10:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 May 2017 13:10:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 14997C011C for ; Wed, 24 May 2017 13:10:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id a0Pz-6otaUOn for ; Wed, 24 May 2017 13:10:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B9D205F23E for ; Wed, 24 May 2017 13:10:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5FD60E0373 for ; Wed, 24 May 2017 13:10:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0F3472193C for ; Wed, 24 May 2017 13:10:04 +0000 (UTC) Date: Wed, 24 May 2017 13:10:04 +0000 (UTC) From: "Etienne Chauchot (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-2347) Elasticsearch IO - test ES 5? MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 24 May 2017 13:10:09 -0000 [ https://issues.apache.org/jira/browse/BEAM-2347?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16022= 861#comment-16022861 ]=20 Etienne Chauchot commented on BEAM-2347: ---------------------------------------- [~sisk] actually, the whole ES IO is only compatible with ES 2.x (this inco= mpatibility is not related to the client version), there is an open ticket = (https://issues.apache.org/jira/browse/BEAM-1637) about providing support f= or ES 5.x. We use ES REST client because REST protocol allows decoupling ES= client and ES server. This REST client appeared in ES v5. There is no rela= tion with the java version. I will resume working on ES v5 support and I'll= update the IT when the IO supports both ES v2.x and ES v5.x > Elasticsearch IO - test ES 5?=20 > ------------------------------ > > Key: BEAM-2347 > URL: https://issues.apache.org/jira/browse/BEAM-2347 > Project: Beam > Issue Type: Bug > Components: sdk-java-extensions > Reporter: Stephen Sisk > Assignee: Jean-Baptiste Onofr=C3=A9 > > Currently, the ES IO transform uses the v5 REST API client, but the integ= ration tests only work against ES 2x > I'm guessing this is because the ES 5x java client only supports java 8 -= https://discuss.elastic.co/t/elasticsearch-5-0-java-api-5-0-on-jdk-7/68222 > I don't know ES particularly well, but I'm guessing it'd be nice to make = the ITs work against ES 5 as well as ES 2. It seems like there are two opti= ons for this:=20 > 1. Make the ITs java-8 only (as is done in HadoopInputFormat ITs) > 2. Switch the ITs to use the ES5 REST API client, which supports java 7. > [~echauchot] am I missing anything here? -- This message was sent by Atlassian JIRA (v6.3.15#6346)