Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7FD80200C7F for ; Wed, 10 May 2017 02:09:11 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 7E638160BC3; Wed, 10 May 2017 00:09:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 77570160BB6 for ; Wed, 10 May 2017 02:09:10 +0200 (CEST) Received: (qmail 54461 invoked by uid 500); 10 May 2017 00:09:09 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 54452 invoked by uid 99); 10 May 2017 00:09:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 May 2017 00:09:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 4B7F018832E for ; Wed, 10 May 2017 00:09:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 8ZyeFdKQIQJJ for ; Wed, 10 May 2017 00:09:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 17AC05FCDA for ; Wed, 10 May 2017 00:09:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 2E4A0E0D2B for ; Wed, 10 May 2017 00:09:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2FB0521E12 for ; Wed, 10 May 2017 00:09:04 +0000 (UTC) Date: Wed, 10 May 2017 00:09:04 +0000 (UTC) From: "Luke Cwik (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (BEAM-2242) Apache Beam Java modules do not correctly shade test artifacts MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 10 May 2017 00:09:11 -0000 [ https://issues.apache.org/jira/browse/BEAM-2242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Cwik updated BEAM-2242: ---------------------------- Description: javap dump of TextIOTest.class Not the unshaded references to org.apache.commons.compress.* {code} Compiled from "TextIOTest.java" public class org.apache.beam.sdk.io.TextIOTest { ... private static java.io.File writeToFile(java.lang.String[], java.lang.String, org.apache.beam.sdk.io.TextIO$CompressionType) throws java.io.IOException; descriptor: ([Ljava/lang/String;Ljava/lang/String;Lorg/apache/beam/sdk/io/TextIO$CompressionType;)Ljava/io/File; Code: 0: getstatic #6 // Field tempFolder:Ljava/nio/file/Path; 3: aload_1 4: invokeinterface #7, 2 // InterfaceMethod java/nio/file/Path.resolve:(Ljava/lang/String;)Ljava/nio/file/Path; 9: invokeinterface #8, 1 // InterfaceMethod java/nio/file/Path.toFile:()Ljava/io/File; 14: astore_3 15: new #9 // class java/io/FileOutputStream 18: dup 19: aload_3 20: invokespecial #10 // Method java/io/FileOutputStream."":(Ljava/io/File;)V 23: astore 4 25: getstatic #11 // Field org/apache/beam/sdk/io/TextIOTest$4.$SwitchMap$org$apache$beam$sdk$io$TextIO$CompressionType:[I 28: aload_2 29: invokevirtual #12 // Method org/apache/beam/sdk/io/TextIO$CompressionType.ordinal:()I 32: iaload 33: tableswitch { // 1 to 5 1: 68 2: 71 3: 85 4: 99 5: 131 default: 145 } 68: goto 157 71: new #13 // class java/util/zip/GZIPOutputStream 74: dup 75: aload 4 77: invokespecial #14 // Method java/util/zip/GZIPOutputStream."":(Ljava/io/OutputStream;)V 80: astore 4 82: goto 157 85: new #15 // class org/apache/commons/compress/compressors/bzip2/BZip2CompressorOutputStream 88: dup 89: aload 4 91: invokespecial #16 // Method org/apache/commons/compress/compressors/bzip2/BZip2CompressorOutputStream."":(Ljava/io/OutputStream;)V 94: astore 4 96: goto 157 99: new #17 // class java/util/zip/ZipOutputStream 102: dup 103: aload 4 105: invokespecial #18 // Method java/util/zip/ZipOutputStream."":(Ljava/io/OutputStream;)V 108: astore 5 110: aload 5 112: new #19 // class java/util/zip/ZipEntry 115: dup 116: ldc #20 // String entry 118: invokespecial #21 // Method java/util/zip/ZipEntry."":(Ljava/lang/String;)V 121: invokevirtual #22 // Method java/util/zip/ZipOutputStream.putNextEntry:(Ljava/util/zip/ZipEntry;)V 124: aload 5 126: astore 4 128: goto 157 131: new #23 // class org/apache/commons/compress/compressors/deflate/DeflateCompressorOutputStream {code} was: javap dump of TextIOTest.class Not the unshaded references to org.apache.commons.compress.* ``` Compiled from "TextIOTest.java" public class org.apache.beam.sdk.io.TextIOTest { ... private static java.io.File writeToFile(java.lang.String[], java.lang.String, org.apache.beam.sdk.io.TextIO$CompressionType) throws java.io.IOException; descriptor: ([Ljava/lang/String;Ljava/lang/String;Lorg/apache/beam/sdk/io/TextIO$CompressionType;)Ljava/io/File; Code: 0: getstatic #6 // Field tempFolder:Ljava/nio/file/Path; 3: aload_1 4: invokeinterface #7, 2 // InterfaceMethod java/nio/file/Path.resolve:(Ljava/lang/String;)Ljava/nio/file/Path; 9: invokeinterface #8, 1 // InterfaceMethod java/nio/file/Path.toFile:()Ljava/io/File; 14: astore_3 15: new #9 // class java/io/FileOutputStream 18: dup 19: aload_3 20: invokespecial #10 // Method java/io/FileOutputStream."":(Ljava/io/File;)V 23: astore 4 25: getstatic #11 // Field org/apache/beam/sdk/io/TextIOTest$4.$SwitchMap$org$apache$beam$sdk$io$TextIO$CompressionType:[I 28: aload_2 29: invokevirtual #12 // Method org/apache/beam/sdk/io/TextIO$CompressionType.ordinal:()I 32: iaload 33: tableswitch { // 1 to 5 1: 68 2: 71 3: 85 4: 99 5: 131 default: 145 } 68: goto 157 71: new #13 // class java/util/zip/GZIPOutputStream 74: dup 75: aload 4 77: invokespecial #14 // Method java/util/zip/GZIPOutputStream."":(Ljava/io/OutputStream;)V 80: astore 4 82: goto 157 85: new #15 // class org/apache/commons/compress/compressors/bzip2/BZip2CompressorOutputStream 88: dup 89: aload 4 91: invokespecial #16 // Method org/apache/commons/compress/compressors/bzip2/BZip2CompressorOutputStream."":(Ljava/io/OutputStream;)V 94: astore 4 96: goto 157 99: new #17 // class java/util/zip/ZipOutputStream 102: dup 103: aload 4 105: invokespecial #18 // Method java/util/zip/ZipOutputStream."":(Ljava/io/OutputStream;)V 108: astore 5 110: aload 5 112: new #19 // class java/util/zip/ZipEntry 115: dup 116: ldc #20 // String entry 118: invokespecial #21 // Method java/util/zip/ZipEntry."":(Ljava/lang/String;)V 121: invokevirtual #22 // Method java/util/zip/ZipOutputStream.putNextEntry:(Ljava/util/zip/ZipEntry;)V 124: aload 5 126: astore 4 128: goto 157 131: new #23 // class org/apache/commons/compress/compressors/deflate/DeflateCompressorOutputStream ``` > Apache Beam Java modules do not correctly shade test artifacts > -------------------------------------------------------------- > > Key: BEAM-2242 > URL: https://issues.apache.org/jira/browse/BEAM-2242 > Project: Beam > Issue Type: Bug > Components: sdk-java-core > Reporter: Luke Cwik > Assignee: Luke Cwik > Priority: Blocker > Fix For: 2.0.0 > > > javap dump of TextIOTest.class > Not the unshaded references to org.apache.commons.compress.* > {code} > Compiled from "TextIOTest.java" > public class org.apache.beam.sdk.io.TextIOTest { > ... > private static java.io.File writeToFile(java.lang.String[], java.lang.String, org.apache.beam.sdk.io.TextIO$CompressionType) throws java.io.IOException; > descriptor: ([Ljava/lang/String;Ljava/lang/String;Lorg/apache/beam/sdk/io/TextIO$CompressionType;)Ljava/io/File; > Code: > 0: getstatic #6 // Field tempFolder:Ljava/nio/file/Path; > 3: aload_1 > 4: invokeinterface #7, 2 // InterfaceMethod java/nio/file/Path.resolve:(Ljava/lang/String;)Ljava/nio/file/Path; > 9: invokeinterface #8, 1 // InterfaceMethod java/nio/file/Path.toFile:()Ljava/io/File; > 14: astore_3 > 15: new #9 // class java/io/FileOutputStream > 18: dup > 19: aload_3 > 20: invokespecial #10 // Method java/io/FileOutputStream."":(Ljava/io/File;)V > 23: astore 4 > 25: getstatic #11 // Field org/apache/beam/sdk/io/TextIOTest$4.$SwitchMap$org$apache$beam$sdk$io$TextIO$CompressionType:[I > 28: aload_2 > 29: invokevirtual #12 // Method org/apache/beam/sdk/io/TextIO$CompressionType.ordinal:()I > 32: iaload > 33: tableswitch { // 1 to 5 > 1: 68 > 2: 71 > 3: 85 > 4: 99 > 5: 131 > default: 145 > } > 68: goto 157 > 71: new #13 // class java/util/zip/GZIPOutputStream > 74: dup > 75: aload 4 > 77: invokespecial #14 // Method java/util/zip/GZIPOutputStream."":(Ljava/io/OutputStream;)V > 80: astore 4 > 82: goto 157 > 85: new #15 // class org/apache/commons/compress/compressors/bzip2/BZip2CompressorOutputStream > 88: dup > 89: aload 4 > 91: invokespecial #16 // Method org/apache/commons/compress/compressors/bzip2/BZip2CompressorOutputStream."":(Ljava/io/OutputStream;)V > 94: astore 4 > 96: goto 157 > 99: new #17 // class java/util/zip/ZipOutputStream > 102: dup > 103: aload 4 > 105: invokespecial #18 // Method java/util/zip/ZipOutputStream."":(Ljava/io/OutputStream;)V > 108: astore 5 > 110: aload 5 > 112: new #19 // class java/util/zip/ZipEntry > 115: dup > 116: ldc #20 // String entry > 118: invokespecial #21 // Method java/util/zip/ZipEntry."":(Ljava/lang/String;)V > 121: invokevirtual #22 // Method java/util/zip/ZipOutputStream.putNextEntry:(Ljava/util/zip/ZipEntry;)V > 124: aload 5 > 126: astore 4 > 128: goto 157 > 131: new #23 // class org/apache/commons/compress/compressors/deflate/DeflateCompressorOutputStream > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)