Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DB670200C7E for ; Mon, 8 May 2017 19:57:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D9FD2160BA2; Mon, 8 May 2017 17:57:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3438A160BA5 for ; Mon, 8 May 2017 19:57:08 +0200 (CEST) Received: (qmail 17236 invoked by uid 500); 8 May 2017 17:57:07 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 17223 invoked by uid 99); 8 May 2017 17:57:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 May 2017 17:57:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id C792C18140E for ; Mon, 8 May 2017 17:57:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id OKb9rkLo0njC for ; Mon, 8 May 2017 17:57:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 701235F367 for ; Mon, 8 May 2017 17:57:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BCB5DE02C8 for ; Mon, 8 May 2017 17:57:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4A4E021B53 for ; Mon, 8 May 2017 17:57:04 +0000 (UTC) Date: Mon, 8 May 2017 17:57:04 +0000 (UTC) From: "Kenneth Knowles (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (BEAM-2219) All TestRunners or no TestRunners should be registered MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 08 May 2017 17:57:09 -0000 [ https://issues.apache.org/jira/browse/BEAM-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001206#comment-16001206 ] Kenneth Knowles edited comment on BEAM-2219 at 5/8/17 5:56 PM: --------------------------------------------------------------- And we should certainly recall that the test jar is the jar for the _test suite_, not a collection of utilities for use in other peoples' tests. was (Author: kenn): And we should certainly recall that the "test jar" is the jar for the _test suite_, not a collection of utilities for use in other peoples' tests. > All TestRunners or no TestRunners should be registered > ------------------------------------------------------ > > Key: BEAM-2219 > URL: https://issues.apache.org/jira/browse/BEAM-2219 > Project: Beam > Issue Type: Bug > Components: runner-dataflow, runner-direct, runner-flink, runner-spark > Reporter: Daniel Halperin > Assignee: Daniel Halperin > Fix For: 2.0.0 > > > Right now, {{TestXRunner}} is key to get unit tests working but is probably not a user-facing runner. However, they seem to be in the {{main}} (not test) artifacts [at least for Dataflow] and to be registered pipeline runners. > We should make all the runners behave the same way w.r.t. test runner registration. -- This message was sent by Atlassian JIRA (v6.3.15#6346)