Mailing-List: contact commits-help@beam.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.apache.org
Date: Fri, 5 May 2017 16:05:04 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@beam.apache.org
Message-ID: <JIRA.13069452.1493990852000.137777.1494000304505@Atlassian.JIRA>
In-Reply-To: <JIRA.13069452.1493990852000@Atlassian.JIRA>
References: <JIRA.13069452.1493990852000@Atlassian.JIRA> <JIRA.13069452.1493990852703@jira-lw-us.apache.org>
Subject: [jira] [Commented] (BEAM-2179) Archetype generate-sources.sh should
 delete old files
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Fri, 05 May 2017 16:05:12 -0000


    [ https://issues.apache.org/jira/browse/BEAM-2179?page=3Dcom.atlassian.=
jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D15998=
506#comment-15998506 ]=20

ASF GitHub Bot commented on BEAM-2179:
--------------------------------------

GitHub user jbonofre opened a pull request:

    https://github.com/apache/beam/pull/2913

    [BEAM-2179] Archetype generate-sources.sh cleanup the existing sources =
before rsync

    Be sure to do all of the following to help us incorporate your contribu=
tion
    quickly and easily:
   =20
     - [X] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [X] Make sure tests pass via `mvn clean verify`.
     - [X] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [X] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.or=
g/licenses/icla.pdf).
   =20
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbonofre/beam BEAM-2179-ARCHETYPES-GENERA=
TE-SOURCES

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2913.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2913
   =20
----

----


> Archetype generate-sources.sh should delete old files
> -----------------------------------------------------
>
>                 Key: BEAM-2179
>                 URL: https://issues.apache.org/jira/browse/BEAM-2179
>             Project: Beam
>          Issue Type: Bug
>          Components: project-management
>            Reporter: Jean-Baptiste Onofr=C3=A9
>            Assignee: Jean-Baptiste Onofr=C3=A9
>
> Examples archetypes use {{generate-sources.sh}} to copy the sources from =
examples modules into the archetype resources. However, it's a simple copy =
and doesn't remove previously copied files (it's just an overwrite).
> It means that if we remove a file in examples module, it's not updated in=
 the archetypes (the file is still present).


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)