Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5B22D200C68 for ; Wed, 3 May 2017 22:34:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 59CDF160BA1; Wed, 3 May 2017 20:34:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A1B23160BB5 for ; Wed, 3 May 2017 22:34:07 +0200 (CEST) Received: (qmail 11160 invoked by uid 500); 3 May 2017 20:34:06 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 11151 invoked by uid 99); 3 May 2017 20:34:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 May 2017 20:34:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 6CF12C3228 for ; Wed, 3 May 2017 20:34:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.001 X-Spam-Level: X-Spam-Status: No, score=-100.001 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id olGES09Ci1En for ; Wed, 3 May 2017 20:34:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id A1BCE5FC64 for ; Wed, 3 May 2017 20:34:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 14468E0D5C for ; Wed, 3 May 2017 20:34:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4D32D21DEF for ; Wed, 3 May 2017 20:34:04 +0000 (UTC) Date: Wed, 3 May 2017 20:34:04 +0000 (UTC) From: "Ahmet Altay (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-2156) Clean up import guards for GCP libraries in the python SDK MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 03 May 2017 20:34:08 -0000 [ https://issues.apache.org/jira/browse/BEAM-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995610#comment-15995610 ] Ahmet Altay commented on BEAM-2156: ----------------------------------- One idea is to have an internal api to check for some extra features and optionally import stuff based on the available features. > Clean up import guards for GCP libraries in the python SDK > ---------------------------------------------------------- > > Key: BEAM-2156 > URL: https://issues.apache.org/jira/browse/BEAM-2156 > Project: Beam > Issue Type: Improvement > Components: sdk-py > Reporter: Vikas Kedigehalli > Assignee: Ahmet Altay > Priority: Minor > > For protecting against environments that do not have gcp libraries installed we have import guards like https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/gcp/datastore/v1/helper.py#L21 which is ugly. Need to come up with a better approach to handle such scenarios. -- This message was sent by Atlassian JIRA (v6.3.15#6346)