Mailing-List: contact commits-help@beam.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.apache.org
Date: Sun, 7 May 2017 03:36:04 +0000 (UTC)
From: "James Xu (JIRA)" <jira@apache.org>
To: commits@beam.apache.org
Message-ID: <JIRA.13068799.1493823574000.145015.1494128164064@Atlassian.JIRA>
In-Reply-To: <JIRA.13068799.1493823574000@Atlassian.JIRA>
References: <JIRA.13068799.1493823574000@Atlassian.JIRA> <JIRA.13068799.1493823574020@jira-lw-us.apache.org>
Subject: [jira] [Resolved] (BEAM-2151) Type mapping inconsistent in
 BeamSqlRow & BeamSqlRowCoder
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 07 May 2017 03:36:07 -0000


     [ https://issues.apache.org/jira/browse/BEAM-2151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Xu resolved BEAM-2151.
----------------------------
       Resolution: Fixed
    Fix Version/s: Not applicable

> Type mapping inconsistent in BeamSqlRow & BeamSqlRowCoder
> ---------------------------------------------------------
>
>                 Key: BEAM-2151
>                 URL: https://issues.apache.org/jira/browse/BEAM-2151
>             Project: Beam
>          Issue Type: Bug
>          Components: dsl-sql
>            Reporter: James Xu
>            Assignee: James Xu
>            Priority: Blocker
>             Fix For: Not applicable
>
>
> In BeamSqlRow, sql FLOAT is mapping to java Float:
> {code:java}
>     case FLOAT:
>       if (!(fieldValue instanceof Float)) {
>         throw new InvalidFieldException(
>             String.format("[%s] doesn't match type [%s]", fieldValue, fieldType));
>       }
>       break;
> {code}
> but in BeamSqlRowCoder, sql FLOAT is treated as java Double:
> {code:java}
>       case DOUBLE:
>       case FLOAT:
>         doubleCoder.encode(value.getDouble(idx), outStream, nested);
>         break;
> {code}
> Let's mapping sql FLOAT consistently to java Float?


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)