Mailing-List: contact commits-help@beam.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.apache.org
Date: Wed, 3 May 2017 20:25:04 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@beam.apache.org
Message-ID: <JIRA.13068782.1493820655000.119571.1493843104250@Atlassian.JIRA>
In-Reply-To: <JIRA.13068782.1493820655000@Atlassian.JIRA>
References: <JIRA.13068782.1493820655000@Atlassian.JIRA> <JIRA.13068782.1493820655904@jira-lw-us.apache.org>
Subject: [jira] [Commented] (BEAM-2150) Support for recursive wildcards in
 GcsPath
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 03 May 2017 20:25:09 -0000


    [ https://issues.apache.org/jira/browse/BEAM-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995591#comment-15995591 ] 

ASF GitHub Bot commented on BEAM-2150:
--------------------------------------

GitHub user meunierd opened a pull request:

    https://github.com/apache/beam/pull/2866

    [BEAM-2150] Relax regex to support wildcard globbing for GCS

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`.
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    Something I've noticed is that Beam's usage of the GCS API doesn't leverage delimiters so we're actually always iterating over the full set of objects after the prefix which is why this PR is so tiny.
    
    Ideally, we can actually specify the delimiter `/` when not using  recursive wildcards (`**`) for some efficiency gains.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/meunierd/beam BEAM-2150-gcs-recursive-wildcards

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2866.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2866
    
----
commit 6d0d6257040a9725b22f4c94bdaa2de388fd2e65
Author: Devon Meunier <devon.meunier@shopify.com>
Date:   2017-05-03T20:22:16Z

    [BEAM-2150] Relax regex to support wildcard globbing for GCS

----


> Support for recursive wildcards in GcsPath
> ------------------------------------------
>
>                 Key: BEAM-2150
>                 URL: https://issues.apache.org/jira/browse/BEAM-2150
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-java-core, sdk-java-gcp
>            Reporter: Devon Meunier
>            Assignee: Devon Meunier
>            Priority: Minor
>
> When working with heavily nested folder structures in Google Cloud Storage, it's great to make use of recursive wildcards, which the current API explicitly does not support.
> This code hasn't been touched in 2 years so it's likely that simply no one's gotten around to it yet.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)