Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 71A58200C80 for ; Wed, 10 May 2017 21:53:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 7053A160B99; Wed, 10 May 2017 19:53:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B69ED160BB4 for ; Wed, 10 May 2017 21:53:07 +0200 (CEST) Received: (qmail 29885 invoked by uid 500); 10 May 2017 19:53:06 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 29867 invoked by uid 99); 10 May 2017 19:53:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 May 2017 19:53:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 77EE7188A56 for ; Wed, 10 May 2017 19:53:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.001 X-Spam-Level: X-Spam-Status: No, score=-100.001 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Z0dQIZ4btv2I for ; Wed, 10 May 2017 19:53:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 78EDF5F27E for ; Wed, 10 May 2017 19:53:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E008DE0D22 for ; Wed, 10 May 2017 19:53:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 380F821E0F for ; Wed, 10 May 2017 19:53:04 +0000 (UTC) Date: Wed, 10 May 2017 19:53:04 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-2052) Windowed file sinks should support dynamic sharding MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 10 May 2017 19:53:08 -0000 [ https://issues.apache.org/jira/browse/BEAM-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005296#comment-16005296 ] ASF GitHub Bot commented on BEAM-2052: -------------------------------------- GitHub user jkff opened a pull request: https://github.com/apache/beam/pull/3060 [BEAM-2052] Cherrypick #3023 and #3059 to release-2.0.0 #3023 implements the functionality, #3059 fixes the build breakage :-| R: @davorbonaci OR @dhalperi You can merge this pull request into a Git repository by running: $ git pull https://github.com/jkff/incubator-beam cp-windowed-writes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/beam/pull/3060.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3060 ---- commit 213eef8bc835c9fa85333356b413cb5886987ba7 Author: Eugene Kirpichov Date: 2017-05-10T19:18:47Z This closes #3023 commit ede0e3ba00c2bd380738e92002f437cada0f0510 Author: Eugene Kirpichov Date: 2017-05-10T19:30:24Z This closes #3059 ---- > Windowed file sinks should support dynamic sharding > --------------------------------------------------- > > Key: BEAM-2052 > URL: https://issues.apache.org/jira/browse/BEAM-2052 > Project: Beam > Issue Type: Bug > Components: sdk-java-core > Reporter: Reuven Lax > Assignee: Reuven Lax > Fix For: 2.0.0 > > > Currently windowed file sinks (WriteFiles and FileBasedSink) require withNumShards to be set explicitly. We should remove this requirement, and allow dynamic output. -- This message was sent by Atlassian JIRA (v6.3.15#6346)