Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9DD59200C79 for ; Thu, 4 May 2017 20:08:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9B38D160B9B; Thu, 4 May 2017 18:08:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EAF7C160BC4 for ; Thu, 4 May 2017 20:08:08 +0200 (CEST) Received: (qmail 90142 invoked by uid 500); 4 May 2017 18:08:08 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 90132 invoked by uid 99); 4 May 2017 18:08:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 May 2017 18:08:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id B0A17C0587 for ; Thu, 4 May 2017 18:08:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id u-xO3xpj-sGT for ; Thu, 4 May 2017 18:08:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 2B4155F405 for ; Thu, 4 May 2017 18:08:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6D8F5E06BF for ; Thu, 4 May 2017 18:08:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 21FA921DEA for ; Thu, 4 May 2017 18:08:04 +0000 (UTC) Date: Thu, 4 May 2017 18:08:04 +0000 (UTC) From: "Thomas Groh (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (BEAM-2021) Fix Java's Coder class hierarchy MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 04 May 2017 18:08:09 -0000 [ https://issues.apache.org/jira/browse/BEAM-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Groh updated BEAM-2021: ------------------------------ Labels: backward-incompatible (was: ) > Fix Java's Coder class hierarchy > -------------------------------- > > Key: BEAM-2021 > URL: https://issues.apache.org/jira/browse/BEAM-2021 > Project: Beam > Issue Type: Improvement > Components: beam-model-runner-api, sdk-java-core > Affects Versions: First stable release > Reporter: Kenneth Knowles > Assignee: Thomas Groh > Labels: backward-incompatible > Fix For: First stable release > > > This is thoroughly out of hand. In the runner API world, there are two paths: > 1. URN plus component coders plus custom payload (in the form of component coders alongside an SdkFunctionSpec) > 2. Custom coder (a single URN) and payload is serialized Java. I think this never has component coders. > The other base classes have now been shown to be extraneous: they favor saving ~3 lines of boilerplate for rarely written code at the cost of readability. Instead they should just be dropped. > The custom payload is an Any proto in the runner API. But tying the Coder interface to proto would be unfortunate from a design perspective and cannot be done anyhow due to dependency hell. -- This message was sent by Atlassian JIRA (v6.3.15#6346)