Mailing-List: contact commits-help@beam.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.apache.org
Date: Tue, 9 May 2017 19:10:04 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@beam.apache.org
Message-ID: <JIRA.13061307.1491267657000.168233.1494357004863@Atlassian.JIRA>
In-Reply-To: <JIRA.13061307.1491267657000@Atlassian.JIRA>
References: <JIRA.13061307.1491267657000@Atlassian.JIRA> <JIRA.13061307.1491267657420@jira-lw-us.apache.org>
Subject: [jira] [Commented] (BEAM-1871) Thin Java SDK Core
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 09 May 2017 19:10:11 -0000


    [ https://issues.apache.org/jira/browse/BEAM-1871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003327#comment-16003327 ] 

ASF GitHub Bot commented on BEAM-1871:
--------------------------------------

GitHub user vikkyrk opened a pull request:

    https://github.com/apache/beam/pull/2996

    [BEAM-1871] [BEAM-1019 ] Shade dependencies in sdks/core

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    - Shade `com.google.guava:guava`, `com.google.protobuf:protobuf-java`, `net.bytebuddy:byte-buddy`, `org.apache.commons:*`
    - Shading `net.bytebuddy` fails the `GcpApiSurfaceTest` with `NoClassDefFoundError` for ` org/apache/beam/sdk/repackaged/net/bytebuddy/jar/asm/tree/MethodNode`. Looks like an issue with how `net.bytebuddy` does shading for `org.objectweb.asm`. Either way the `ApiSurfaceTest` should be fixed to be able to prune and load classes lazily. For release-2.0.0 we catch and ignore any class loading errors.  

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vikkyrk/incubator-beam shade_2.0.0

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2996.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2996
    
----
commit feee8daa0f90eb779edb44b4cfafcee6b7ac7faf
Author: Vikas Kedigehalli <vikasrk@google.com>
Date:   2017-05-09T18:41:29Z

    Shade dependencies in sdks/core

----


> Thin Java SDK Core
> ------------------
>
>                 Key: BEAM-1871
>                 URL: https://issues.apache.org/jira/browse/BEAM-1871
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Daniel Halperin
>            Assignee: Vikas Kedigehalli
>             Fix For: 2.0.0
>
>
> Before first stable release we need to thin out {{sdk-java-core}} module. Some candidates for removal, but not a non-exhaustive list:
> {{sdk/io}}
> * anything BigQuery related
> * anything PubSub related
> * everything Protobuf related
> * TFRecordIO
> * XMLSink
> {{sdk/util}}
> * Everything GCS related
> * Everything Backoff related
> * Everything Google API related: ResponseInterceptors, RetryHttpBackoff, etc.
> * Everything CloudObject-related
> * Pubsub stuff
> {{sdk/coders}}
> * JAXBCoder
> * TableRowJsoNCoder


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)