Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E4796200C70 for ; Thu, 4 May 2017 22:53:11 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E3124160BB0; Thu, 4 May 2017 20:53:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 36942160B9B for ; Thu, 4 May 2017 22:53:11 +0200 (CEST) Received: (qmail 11593 invoked by uid 500); 4 May 2017 20:53:10 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 11584 invoked by uid 99); 4 May 2017 20:53:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 May 2017 20:53:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 14F43188A36 for ; Thu, 4 May 2017 20:53:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id susZaeAjGOPd for ; Thu, 4 May 2017 20:53:09 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id C93605FDA5 for ; Thu, 4 May 2017 20:53:07 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D4D97E0D5F for ; Thu, 4 May 2017 20:53:06 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3F1D021DF4 for ; Thu, 4 May 2017 20:53:05 +0000 (UTC) Date: Thu, 4 May 2017 20:53:05 +0000 (UTC) From: "Aviem Zur (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (BEAM-1763) TestPipeline should ensure that all assertions succeeded MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 04 May 2017 20:53:12 -0000 [ https://issues.apache.org/jira/browse/BEAM-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aviem Zur resolved BEAM-1763. ----------------------------- Resolution: Implemented > TestPipeline should ensure that all assertions succeeded > -------------------------------------------------------- > > Key: BEAM-1763 > URL: https://issues.apache.org/jira/browse/BEAM-1763 > Project: Beam > Issue Type: Sub-task > Components: sdk-java-core > Reporter: Thomas Groh > Assignee: Aviem Zur > Fix For: First stable release > > > This doesn't need to be part of each {{PipelineRunner}} implementation if it goes through the {{PipelineResult}} APIs. The assertion can be of the form that if the Pipeline is finished, then the number of successful assertions is equal to the total number of assertions. > Suggested solution: > For runners which support metrics, use the counters for successful/failed assertions and compare them to expected number of assertions. > Runners which do not support metrics should either implement metrics or override {{PAssert}} in a way that verifies its execution. -- This message was sent by Atlassian JIRA (v6.3.15#6346)