Mailing-List: contact commits-help@beam.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.apache.org
Date: Mon, 15 May 2017 17:08:04 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@beam.apache.org
Message-ID: <JIRA.13045689.1487870561000.212664.1494868084135@Atlassian.JIRA>
In-Reply-To: <JIRA.13045689.1487870561000@Atlassian.JIRA>
References: <JIRA.13045689.1487870561000@Atlassian.JIRA> <JIRA.13045689.1487870561373@jira-lw-us.apache.org>
Subject: [jira] [Commented] (BEAM-1542) Need Source/Sink for Spanner
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 15 May 2017 17:08:10 -0000


    [ https://issues.apache.org/jira/browse/BEAM-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010912#comment-16010912 ] 

ASF GitHub Bot commented on BEAM-1542:
--------------------------------------

GitHub user dhalperi opened a pull request:

    https://github.com/apache/beam/pull/3146

    [BEAM-1542] Takeover #2166 with initial support for SpannerIO.Write

    This takes over #2166, and it is not really ready for use. To be properly ready, it needs:
    
    * Many style guide fixes.
    * Comprehensive javadoc.
    * Unit tests and integration tests.
    
    However, given that 2.0.0 was just cut and there is a month until next release, I believe it should be okay to merge this as @mairbek and @NextDevBoard are actively working on it.
    
    We will pull it from the 2.1.0 release if these major issues are not addressed before then.
    
    R: @davorbonaci 
    CC: @mairbek @nextdevboard

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhalperi/beam takeover-2166

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3146.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3146
    
----
commit 4392de9be272c045a9854340f887e420f25f0f4a
Author: MOLIG004 <guy.molinari@disney.com>
Date:   2017-05-04T16:21:23Z

    Initial implementation of SpannerIO.Write
    
    This closes #2166.

commit b092be8df5cd96012c4d67b3defbd3554707edfe
Author: Dan Halperin <dhalperi@google.com>
Date:   2017-05-04T17:42:07Z

    Minor style, compilation, javadoc fixups

commit e16339a3e699d7bea30f3f3a703b4c7c3ead0f59
Author: Dan Halperin <dhalperi@google.com>
Date:   2017-05-04T17:48:54Z

    Fix spanner dependency management
    
    Also minor cleanup alphabetization in root pom.xml

commit 9798534793286aeb3deacdc0e30f63032b6077fe
Author: Dan Halperin <dhalperi@google.com>
Date:   2017-05-04T17:48:24Z

    Delete SpannerCSVLoader
    
    This is not appropriate for examples. SpannerIO should be well-javadoced
    and integration tested.

----


> Need Source/Sink for Spanner
> ----------------------------
>
>                 Key: BEAM-1542
>                 URL: https://issues.apache.org/jira/browse/BEAM-1542
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-java-gcp
>            Reporter: Guy Molinari
>            Assignee: Guy Molinari
>
> Is there a source/sink for Spanner in the works?   If not I would gladly give this a shot.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)