Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 35D93200C6C for ; Fri, 5 May 2017 19:19:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 34611160BBE; Fri, 5 May 2017 17:19:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 79EC9160BAA for ; Fri, 5 May 2017 19:19:08 +0200 (CEST) Received: (qmail 13505 invoked by uid 500); 5 May 2017 17:19:07 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 13487 invoked by uid 99); 5 May 2017 17:19:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 May 2017 17:19:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 43E8A1A00A6 for ; Fri, 5 May 2017 17:19:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id i0WdRqumdIpj for ; Fri, 5 May 2017 17:19:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 0233160DD2 for ; Fri, 5 May 2017 17:19:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8C3A1E06C6 for ; Fri, 5 May 2017 17:19:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 482A221DEA for ; Fri, 5 May 2017 17:19:05 +0000 (UTC) Date: Fri, 5 May 2017 17:19:05 +0000 (UTC) From: "Robert Bradshaw (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-1327) Replace OutputTimeFn with enum MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 05 May 2017 17:19:09 -0000 [ https://issues.apache.org/jira/browse/BEAM-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15998603#comment-15998603 ] Robert Bradshaw commented on BEAM-1327: --------------------------------------- I had re-opened this to make sure the APIs between SDKs are aligned. Instead, I've created https://issues.apache.org/jira/browse/BEAM-2184 which may just involve changing the name in Python. > Replace OutputTimeFn with enum > ------------------------------ > > Key: BEAM-1327 > URL: https://issues.apache.org/jira/browse/BEAM-1327 > Project: Beam > Issue Type: New Feature > Components: sdk-java-core > Reporter: Kenneth Knowles > Assignee: Kenneth Knowles > Priority: Minor > Labels: backward-incompatible > Fix For: First stable release > > > The class {{OutputTimeFn}} is overkill for a Fn API crossing. There are only three sensible values known: MIN, MAX, EOW. The interface is right for implementing these, but the full class is left over from the days when there was little cost to shipping new kinds of fns. An enum is concise. > This can be done "mostly" backwards compatibly with legacy adapters in place, but might be less confusing without them. -- This message was sent by Atlassian JIRA (v6.3.15#6346)