Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B155B200CA3 for ; Tue, 2 May 2017 22:32:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B0014160B9D; Tue, 2 May 2017 20:32:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 06974160BBE for ; Tue, 2 May 2017 22:32:08 +0200 (CEST) Received: (qmail 72746 invoked by uid 500); 2 May 2017 20:32:08 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 72736 invoked by uid 99); 2 May 2017 20:32:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 May 2017 20:32:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id D314ACF7BB for ; Tue, 2 May 2017 20:32:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id cEav-Tx1MMsU for ; Tue, 2 May 2017 20:32:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 48AF15FDE5 for ; Tue, 2 May 2017 20:32:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B6098E0045 for ; Tue, 2 May 2017 20:32:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6F42421DEF for ; Tue, 2 May 2017 20:32:04 +0000 (UTC) Date: Tue, 2 May 2017 20:32:04 +0000 (UTC) From: "Kenneth Knowles (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (BEAM-1327) Replace OutputTimeFn with enum MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 02 May 2017 20:32:09 -0000 [ https://issues.apache.org/jira/browse/BEAM-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kenneth Knowles resolved BEAM-1327. ----------------------------------- Resolution: Fixed > Replace OutputTimeFn with enum > ------------------------------ > > Key: BEAM-1327 > URL: https://issues.apache.org/jira/browse/BEAM-1327 > Project: Beam > Issue Type: New Feature > Components: sdk-java-core > Reporter: Kenneth Knowles > Assignee: Kenneth Knowles > Priority: Minor > Labels: backward-incompatible > Fix For: First stable release > > > The class {{OutputTimeFn}} is overkill for a Fn API crossing. There are only three sensible values known: MIN, MAX, EOW. The interface is right for implementing these, but the full class is left over from the days when there was little cost to shipping new kinds of fns. An enum is concise. > This can be done "mostly" backwards compatibly with legacy adapters in place, but might be less confusing without them. -- This message was sent by Atlassian JIRA (v6.3.15#6346)