Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B3137200C88 for ; Fri, 19 May 2017 00:42:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B17E1160BD0; Thu, 18 May 2017 22:42:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0540E160BB5 for ; Fri, 19 May 2017 00:42:07 +0200 (CEST) Received: (qmail 68759 invoked by uid 500); 18 May 2017 22:42:07 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 68747 invoked by uid 99); 18 May 2017 22:42:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 May 2017 22:42:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D4A791A063F for ; Thu, 18 May 2017 22:42:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -96.911 X-Spam-Level: X-Spam-Status: No, score=-96.911 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, TVD_SUBJ_WIPE_DEBT=2.291, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id NlVTBF4ejCiD for ; Thu, 18 May 2017 22:42:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E7C455FB5C for ; Thu, 18 May 2017 22:42:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 788C6E01A8 for ; Thu, 18 May 2017 22:42:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id DF41621B55 for ; Thu, 18 May 2017 22:42:04 +0000 (UTC) Date: Thu, 18 May 2017 22:42:04 +0000 (UTC) From: "Kenneth Knowles (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (BEAM-230) Remove WindowedValue#valueInEmptyWindows MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 18 May 2017 22:42:08 -0000 [ https://issues.apache.org/jira/browse/BEAM-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016574#comment-16016574 ] Kenneth Knowles edited comment on BEAM-230 at 5/18/17 10:41 PM: ---------------------------------------------------------------- This is not subject to backwards compatibility - just some runners-core-bound stuff in util. It should still be removed, as it is a bit dangerous and semantically hazy. was (Author: kenn): This is not subject to backwards compatibility. It should still be removed, as it is a bit dangerous and semantically hazy. > Remove WindowedValue#valueInEmptyWindows > ---------------------------------------- > > Key: BEAM-230 > URL: https://issues.apache.org/jira/browse/BEAM-230 > Project: Beam > Issue Type: Improvement > Components: sdk-java-core > Reporter: Thomas Groh > Fix For: Not applicable > > > A WindowedValue in no windows does not exist, and can be dropped by a runner at any time. > We should also assert that any collection of windows is nonempty when creating a new WindowedValue. If a user wants to drop an element, they should explicitly filter it out rather than expecting it to be dropped by the runner. -- This message was sent by Atlassian JIRA (v6.3.15#6346)