beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dhalperi <...@git.apache.org>
Subject [GitHub] beam pull request #3270: InstantCoder: stop boxing Longs unnecessarily
Date Wed, 31 May 2017 16:39:56 GMT
GitHub user dhalperi opened a pull request:

    https://github.com/apache/beam/pull/3270

    InstantCoder: stop boxing Longs unnecessarily

    In encode, and similar in decode, the existing path goes
      Instant->long (inside of converter)
      long->Long (returned from converter)
      Long->long (inside of LongCoder).
    
    This is a relatively small improvement, but as we encode timestamps
    for every single element, this is likely to make a difference in
    lightweight stages of pipelines.
    
    R: @lukecwik @bjchambers 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhalperi/beam instantcoder

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3270.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3270
    
----
commit 1945c9ddf0aa9545709413c262737bc84a444d4c
Author: Dan Halperin <dhalperi@google.com>
Date:   2017-05-26T23:39:13Z

    InstantCoder: stop boxing Longs unnecessarily
    
    In encode, and similar in decode, the existing path goes
      Instant->long (inside of converter)
      long->Long (returned from converter)
      Long->long (inside of LongCoder).
    
    This is a relatively small improvement, but as we encode timestamps
    for every single element, this is likely to make a difference in
    lightweight stages of pipelines.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message