beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkff <...@git.apache.org>
Subject [GitHub] beam pull request #3261: Rephrases messages on RetryHttpRequestInitializer
Date Tue, 30 May 2017 21:25:33 GMT
GitHub user jkff opened a pull request:

    https://github.com/apache/beam/pull/3261

    Rephrases messages on RetryHttpRequestInitializer

    "will NOT retry" messages are confusing some customers into thinking
    that an entire high-level operation inside a Beam job, involving this
    request as an implementation detail, will not be retried (e.g. a BigQuery
    import etc.)
    
    In reality there's many levels of retries and
    RetryHttpRequestInitializer can not be aware of them. Retrying at a
    higher level may or may not happen, and it's up to higher-level
    components to log that (they usually do).
    
    R: @lukecwik 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jkff/incubator-beam retry-message

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3261.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3261
    
----
commit ab9b77db3dd263f432b6535d96495bb36fa4fe0e
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2017-05-30T21:16:22Z

    Rephrases messages on RetryHttpRequestInitializer
    
    "will NOT retry" messages are confusing some customers into thinking
    that an entire high-level operation inside a Beam job, involving this
    request as an implementation detail, will not be retried (e.g. a BigQuery
    import etc.)
    
    In reality there's many levels of retries and
    RetryHttpRequestInitializer can not be aware of them. Retrying at a
    higher level may or may not happen, and it's up to higher-level
    components to log that (they usually do).

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message