beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mairbek <...@git.apache.org>
Subject [GitHub] beam pull request #3259: [BEAM-2379] Avoid reading projectId from environmen...
Date Tue, 30 May 2017 19:15:59 GMT
GitHub user mairbek opened a pull request:

    https://github.com/apache/beam/pull/3259

     [BEAM-2379] Avoid reading projectId from environment variable in tests.

    SpannerOptions.Builder requires projectId to be not-null.
    
    Was green because I had GOOGLE_APPLICATION_CREDENTIALS configured on my dev machine. Same
for Jenkins, I guess.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mairbek/beam fixtest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3259.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3259
    
----
commit 4a4551a0cebfbec3f5f63b115f4e21e94163b979
Author: Mairbek Khadikov <mairbek@google.com>
Date:   2017-05-30T18:54:55Z

    Avoid reading projectId from environment variable in tests.
    
    SpannerOptions.Builder requires projectId to be not-null.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message