beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] beam pull request #3173: [BEAM-2316] Restore non-recursive globs in GcsUtil
Date Thu, 18 May 2017 15:34:28 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/3173

    [BEAM-2316] Restore non-recursive globs in GcsUtil

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    R: @meunierd this is what I have in mind as a quick fix, basically. I stopped short of
actually parsing the glob and translating it...

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam GcsUtil

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3173.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3173
    
----
commit 578ccfd53286a654fad6bb412cca901907394cd8
Author: Kenneth Knowles <klk@google.com>
Date:   2017-05-18T15:32:29Z

    Restore non-recursive globs in GcsUtil

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message