beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From markflyhigh <...@git.apache.org>
Subject [GitHub] beam pull request #3171: [BEAM-2164] Fix generate-sources.sh if directory co...
Date Wed, 17 May 2017 21:31:50 GMT
GitHub user markflyhigh opened a pull request:

    https://github.com/apache/beam/pull/3171

    [BEAM-2164] Fix generate-sources.sh if directory contains space

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    [generate-sources.sh](https://github.com/apache/beam/blob/master/sdks/java/maven-archetypes/examples/generate-sources.sh)
is executed in beam-sdks-java-maven-archetypes-examples and beam-sdks-java-maven-archetypes-examples-java8.
If project directory contains space, mvn build of the two module will fail because the space
character is not handled properly.
    
    Test is done by successfully running mvn clean build. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markflyhigh/incubator-beam fix-generate-sources

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3171.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3171
    
----
commit e8bc4f994e10b0d70f3e1123904360d5fb45c3b3
Author: Mark Liu <markliu@google.com>
Date:   2017-05-17T21:24:25Z

    [BEAM-2164] Fix generate-sources.sh if directory contains space

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message