beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From XuMingmin <>
Subject [GitHub] beam pull request #3135: [BEAM-2234] expose PCollection of each RelNode
Date Sat, 13 May 2017 04:21:18 GMT
GitHub user XuMingmin opened a pull request:

    [BEAM-2234] expose PCollection of each RelNode

    Change the return of `buildBeamPipeline` to `PCollection<BeamSQLRow>`, this helps
    1). donot need to manage the upstream-downstream in `BeamPipelineCreator` as execution
tree already have it;
    2). easy for unit test with `PAssert`;
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](

You can merge this pull request into a Git repository by running:

    $ git pull BEAM-2234

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3135
commit ebd263c9e29515038b1ee00dc423da44bef65362
Author: mingmxu <>
Date:   2017-05-13T04:14:29Z

    change return type of buildBeamPipeline to `PCollection<BeamSQLRow>`


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message