beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] beam pull request #3080: [BEAM-2259] Do not use infinite lateness in Reshuff...
Date Thu, 11 May 2017 16:32:22 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/3080

    [BEAM-2259] Do not use infinite lateness in Reshuffle

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    Elements will be dropped only if the window they are assigned to is
    expired, which can generally be performed arbitrarily.
    
    Using infinite allowed lateness can cause an IllegalStateException if
    the ReduceFnRunner observes certain combinations of timers and elements,
    and attempts to buffer an element, setting a watermark hold for window
    expiry (which is past the end of time).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam reshuffle_exception

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3080.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3080
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message