beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lukecwik <...@git.apache.org>
Subject [GitHub] beam pull request #3061: Cherry-pick #3034: [BEAM-2242] Ensure that jars are...
Date Wed, 10 May 2017 20:13:08 GMT
GitHub user lukecwik opened a pull request:

    https://github.com/apache/beam/pull/3061

    Cherry-pick #3034: [BEAM-2242] Ensure that jars are shaded correctly by running the jar
plugin before the shade plugin

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lukecwik/incubator-beam beam2242

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3061.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3061
    
----
commit 4324d9d99bd3444ca0f9fbde48b13ca214b7c318
Author: Luke Cwik <lcwik@google.com>
Date:   2017-05-10T02:07:36Z

    [BEAM-2242] Ensure that jars are shaded correctly by running the jar plugin before the
shade plugin
    
    This required listing the maven jar plugin earlier within the file so that the jar/test
jar ran before shade within the package phase.
    
    I also update the maven shade plugin version in archetypes to pickup the fixes in the
service file transformer and dropped the usage of finalName in the shade plugin so all artifacts
are named the same way.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message