beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dhalperi <...@git.apache.org>
Subject [GitHub] beam pull request #3050: [BEAM-2249] Correctly handle partial reads in AvroS...
Date Wed, 10 May 2017 17:18:58 GMT
GitHub user dhalperi opened a pull request:

    https://github.com/apache/beam/pull/3050

    [BEAM-2249] Correctly handle partial reads in AvroSource

    R: @lukecwik 
    
    These were the only uses of `InputStream#read(byte[])` or `InputStream#read(byte[], int,
int)` that were clearly not handled correctly. All other uses:
    
    * ZipInputStream: https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/io/CompressedSource.java#L206
    * AvroSource: https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/io/AvroSource.java#L787
    * ExposedByteArrayInputStream https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/util/ExposedByteArrayInputStream.java#L41
    * Twice in StreamUtils: https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/util/StreamUtils.java#L48
    
    I believe these last are correct as they first assert bytes are available.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhalperi/beam io-read-fully

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3050.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3050
    
----
commit da314112d262007266aece731bd3914cbe22b258
Author: Dan Halperin <dhalperi@google.com>
Date:   2017-05-10T17:11:53Z

    [BEAM-2249] Correctly handle partial reads in AvroSource

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message