beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] beam pull request #2999: [BEAM-2223] Do not register TestSparkPipelineOption...
Date Tue, 09 May 2017 19:48:15 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/2999

    [BEAM-2223] Do not register TestSparkPipelineOptions to avoid hard hamcrest dep

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    We have an undocumented requirement that no subclass of `TestPipelineOptions` can be registered.
We do not indicate a hard dependency on hamcrest, but test options has one and it will crash
on registration (or classloading in general) if the user does not provide it.
    
    I see this change as a short term solution, making the Spark registrar analogous to all
the other runners. It allows Java 8 examples to get past the point of registration.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam java8-examples

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2999.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2999
    
----
commit 847c90f93efb77d4d05284ca6855ebbd936c8e3a
Author: Kenneth Knowles <klk@google.com>
Date:   2017-05-09T19:44:19Z

    Do not register TestSparkPipelineOptions to avoid hard hamcrest dep

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message