beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sb2nov <...@git.apache.org>
Subject [GitHub] beam pull request #2963: [BEAM-1925] validate DoFn at pipeline creation time
Date Mon, 08 May 2017 20:46:30 GMT
GitHub user sb2nov opened a pull request:

    https://github.com/apache/beam/pull/2963

    [BEAM-1925] validate DoFn at pipeline creation time

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    R: @robertwb PTAL 
    
    Same changes as https://github.com/apache/beam/pull/2848 without the new file creation.
    
    The performance seems identical to master on the benchmark gist.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sb2nov/beam BEAM-1925-validate-dofn-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2963.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2963
    
----
commit 6ee4c243b7f1a942f66f4f6f5fb19b32fb334a7c
Author: Sourabh Bajaj <sourabhbajaj@google.com>
Date:   2017-05-08T20:33:15Z

    [BEAM-1925] validate DoFn at pipeline creation time

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message