beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertwb <>
Subject [GitHub] beam pull request #2933: [BEAM-2166] Use contextless encode/decode by defaul...
Date Sat, 06 May 2017 01:07:17 GMT
GitHub user robertwb opened a pull request:

    [BEAM-2166]  Use contextless encode/decode by default.

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](

You can merge this pull request into a Git repository by running:

    $ git pull context-encode-decode

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2933
commit ecefdd9518e0ba4a29a627aed661e45a494a1810
Author: Robert Bradshaw <>
Date:   2017-05-05T23:20:37Z

    Remove explicit used of nested contexts.
        find . -type f -name '*.java' | xargs sed -i '' 's/\([.]..code[(].*\),  *context.nested..[)]/\1)/'
        find . -type f -name '*.java' | xargs sed -i '' 's/\([.]..code[(].*\),  *nestedContext[)]/\1)/'
        find . -type f -name '*.java' | xargs sed -i '' 's/\([.]..code[(].*\),  *Context.NESTED[)]/\1)/'
        find . -type f -name '*.java' | xargs sed -i '' 's/\([.]..code[(].*\),  *[^ ]*.Context.NESTED[)]/\1)/'
    Added back explicit context in due to compile error.

commit f2bd184a86a743823bb7d9412c279399ec7ec259
Author: Robert Bradshaw <>
Date:   2017-05-05T23:36:47Z

    Remove contexts from coders where they'll never be used.

commit dad18a0414d4eda561437d896b3dad075e7f0ac9
Author: Robert Bradshaw <>
Date:   2017-05-06T00:24:02Z

    automated context removal or redirection

commit f6a414e56ef47a8894243374b0909078eba9147e
Author: Robert Bradshaw <>
Date:   2017-05-06T00:27:13Z

    get it compiling

commit 77059753f8332ff49aa2f60f2992a7b276e56f46
Author: Robert Bradshaw <>
Date:   2017-05-06T00:35:35Z

    Remove en/decodeOuter and default encode/decode methods.
    Now only the context-free encode() and decode() methods are abstract.


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message